Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: TCN Layer (temporal convolutional networks) #661

Closed
shun-lin opened this issue Nov 4, 2019 · 3 comments
Closed

Feature Request: TCN Layer (temporal convolutional networks) #661

shun-lin opened this issue Nov 4, 2019 · 3 comments

Comments

@shun-lin
Copy link
Contributor

shun-lin commented Nov 4, 2019

Describe the feature and the current behavior/state.

The feature is for adding the different layers introduced in An Empirical Evaluation of Generic Convolutional and Recurrent Networks for Sequence Modeling paper to tfa.layers. There is already existed an Keras implementation here: https://github.com/philipperemy/keras-tcn/, I feel like this is helpful and would have more visibility in tfa so I ask him in this issue if I can help out porting the TCN layers portion into tfa and he says yes :)
If you feel like this would be a good addition let me know, very happy to contribute.

Relevant information

Which API type would this fall under (layer, metric, optimizer, etc.)
layer

Who will benefit with this feature?
Developers who want to experiment with TCN layers.

Any other info.
Github issue that initialize the conversation to port TCN layers from @philipperemy's repo to tensorflow addons (see last two comments in this issue).
philipperemy/keras-tcn#73

@WindQAQ
Copy link
Member

WindQAQ commented Nov 4, 2019

Good news! This is indeed in the scope of addons. Feel free to file a PR for it. Thanks!

@shun-lin
Copy link
Contributor Author

shun-lin commented Nov 4, 2019

@WindQAQ thanks! Will do so when I have time :)

@seanpmorgan
Copy link
Member

TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision:
TensorFlow Addons Wind Down

Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA:
Keras
Keras-CV
Keras-NLP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants