Free disk size (todo) #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO(tfds): Should try to estimate the available free disk space (if possible) and raise an error if not.
Closed
rsepassi
reviewed
Mar 11, 2019
|
Thank you! |
rsepassi
suggested changes
Mar 14, 2019
1 - I called method without parameters. I forgot after changing method location. 2 - Fixed free_disk_size method calculation to byte.
rsepassi
suggested changes
Mar 14, 2019
|
Up to you. Fine by me to update in place.
…On Thu, Mar 14, 2019 at 12:18 PM us ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tensorflow_datasets/core/utils/py_utils.py
<#172 (comment)>:
> @@ -275,3 +275,9 @@ def rgetattr(obj, attr, *args):
def _getattr(obj, attr):
return getattr(obj, attr, *args)
return functools.reduce(_getattr, [obj] + attr.split("."))
+
+
+def free_disk_size(directory):
+ stat = os.statvfs(directory)
Should I closed this pr and create a more clean ?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#172 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABEGWxKRD5m0M-neBI63S_HLPoQTFIW4ks5vWqCCgaJpZM4bh7nF>
.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO(tfds): Should try to estimate the available free disk space (if possible) and raise an error if not.
I made many wrong mistakes in the previous pull request. Now I cleared it.