Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pylint errors in Image Classification datasets #1774

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vijayphoenix
Copy link
Contributor

Fix some of #1644

@googlebot googlebot added the cla: yes Author has signed CLA label Mar 31, 2020
@tfds-bot tfds-bot added the community:please_review Community - We need your help to review this PR. label Mar 31, 2020
@Conchylicultor Conchylicultor added the py3-migration Typing annotations label Apr 1, 2020
Copy link

@sherry-s-yuan sherry-s-yuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some suggestions: change names of the split generator to tfds.Split.Test etc. One example of such is in file cars196.py line 184, 197. This will make maintenance an easier process in the future. Thank you for your hard work fixing these! Everything looks fine except those small places, if fixing these small things is too annoying, feel free to just submit as it is.

@tfds-bot tfds-bot added author:please_respond Author - please respond to the recent comments. and removed community:please_review Community - We need your help to review this PR. labels Apr 6, 2020
@tfds-bot tfds-bot added community:is_reviewing This PR is being reviewed by community member. and removed author:please_respond Author - please respond to the recent comments. labels Apr 6, 2020
@tfds-bot tfds-bot added tfds:please_review TFDS team: please review this PR. and removed community:is_reviewing This PR is being reviewed by community member. labels Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Author has signed CLA py3-migration Typing annotations tfds:please_review TFDS team: please review this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants