Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regex error for windows #1889

Merged
merged 1 commit into from Apr 16, 2020
Merged

Fix regex error for windows #1889

merged 1 commit into from Apr 16, 2020

Conversation

vijayphoenix
Copy link
Contributor

Fix #1888

@googlebot googlebot added the cla: yes Author has signed CLA label Apr 16, 2020
Conchylicultor
Conchylicultor approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@Conchylicultor Conchylicultor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix

@tfds-bot tfds-bot added the kokoro:run Run Kokoro tests label Apr 16, 2020
@kokoro-team kokoro-team removed the kokoro:run Run Kokoro tests label Apr 16, 2020
@tfds-bot tfds-bot added the tfds:ready_to_merge This PR is ready to be merged. label Apr 16, 2020
@tfds-copybara tfds-copybara merged commit 8c85e32 into tensorflow:master Apr 16, 2020
@vijayphoenix
Copy link
Contributor Author

vijayphoenix commented Apr 16, 2020 •
edited

@Conchylicultor To prevent these types of errors, we can consider adding Kokoro tests for windows and mac. Is it feasible though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conchylicultor Conchylicultor Conchylicultor approved these changes

Assignees
No one assigned
Labels
cla: yes Author has signed CLA tfds:ready_to_merge This PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Horses_or_Humans - No Examples Yielded
6 participants
@vijayphoenix @Conchylicultor @googlebot @kokoro-team @tfds-copybara @tfds-bot