Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tfds/core bugs on windows #1916

Merged
merged 4 commits into from Apr 21, 2020
Merged

Fix tfds/core bugs on windows #1916

merged 4 commits into from Apr 21, 2020

Conversation

vijayphoenix
Copy link
Contributor

@vijayphoenix vijayphoenix commented Apr 19, 2020 •
edited

Related #1911 (comment)

TODO:

  • Fix download_manger_test.py
  • Fix dataset_info_test.py
  • Fix tfrecords_reader_test.py
  • Fix features_test.py
  • Fix extractor_test.py
  • Fix gcs_utils_test.py
  • Fix py_utils_test.py

@googlebot googlebot added the cla: yes Author has signed CLA label Apr 19, 2020
@tfds-bot tfds-bot added the community:please_review Community - We need your help to review this PR. label Apr 19, 2020
Conchylicultor
Conchylicultor approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@Conchylicultor Conchylicultor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good.

@tfds-bot tfds-bot added kokoro:run Run Kokoro tests and removed community:please_review Community - We need your help to review this PR. labels Apr 20, 2020
@kokoro-team kokoro-team removed the kokoro:run Run Kokoro tests label Apr 20, 2020
@tfds-bot tfds-bot added the tfds:ready_to_merge This PR is ready to be merged. label Apr 20, 2020
@tfds-bot tfds-bot added kokoro:run Run Kokoro tests and removed tfds:ready_to_merge This PR is ready to be merged. labels Apr 20, 2020
@kokoro-team kokoro-team removed the kokoro:run Run Kokoro tests label Apr 20, 2020
@tfds-bot tfds-bot added the kokoro:run Run Kokoro tests label Apr 20, 2020
@kokoro-team kokoro-team removed the kokoro:run Run Kokoro tests label Apr 20, 2020
@vijayphoenix
Copy link
Contributor Author

vijayphoenix commented Apr 20, 2020 •
edited

@Conchylicultor Fixed some more tfds/core bugs.
Please review them.

To fix download_manger_test.py and gcs_util_test.py on windows will require a lot of changes in both tfds code and test files.
So, maybe we can fix them later on.

Edit: I just came to know that TensorFlow has no support for Google Cloud Storage (GCS) on Windows operating systems.

@tfds-bot tfds-bot added the tfds:needs_final_approval TFDS team: this PR was already approved, but author added some small changes. PTAL label Apr 20, 2020
@tfds-copybara tfds-copybara merged commit 4367027 into tensorflow:master Apr 21, 2020
@vijayphoenix vijayphoenix mentioned this pull request Oct 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conchylicultor Conchylicultor Awaiting requested review from Conchylicultor

Assignees
No one assigned
Labels
cla: yes Author has signed CLA tfds:needs_final_approval TFDS team: this PR was already approved, but author added some small changes. PTAL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vijayphoenix @Conchylicultor @googlebot @kokoro-team @tfds-copybara @tfds-bot