Modelnet #194
Closed
Modelnet #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dataset info here. |
|
I have no idea why this presubmit is failing... can't install tensorflow-datasets? All I did was add a lazy import... |
cyfra
added
the
community:please_review
|
Hi @jackd would you like to add this dataset under tensorflow_graphics instead? I finished the PR for modelnet40 (point cloud version, used by pointnet) and I randomly bumped in your pull request. |
|
@ataiya Yeah, I gave up waiting here/submitting any more PRs and just made a separate repository with this and some other shape stuff. If it's likely to get through at graphics then I'm happy to clean some of them up, but I wouldn't mind getting a clearer idea of what'll be prioritized at the other end before I make too many PRs like this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... this was supposed to just be modelnet10/40 with tri-mesh and point cloud sampling... then I found this and extending it to their sampled data/shapenet parts didn't seem too much more. Apologies for not splitting it up.
One issue I haven't been able to resolve is repeated downloads for different configs of the same dataset.
builder.info.download_checksumsjust seem to disappear occasionally between runs. Could be related to this, but I suspect it's a different issue.Note sure what the feeling is regarding
volumesubmodule - just seemed like a good catch-all for point cloud/mesh/voxels. I suspect there'll be less controversial aspects here compared to this PR, but once either is resolved I'm happy to modify the other so that all shapenet stuff is sitting together (assuming image -> volume datasets are morevolume-ous thanimage-ish).Also happy to add the shapenet ICCV2017 reconstruction track (to partner the point cloud segmentation one) once shape issues with RLE encodings have been resolved.