Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add try_import context manager #1947

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Add try_import context manager #1947

wants to merge 17 commits into from

Conversation

vijayphoenix
Copy link
Contributor

Fix #1945

@googlebot googlebot added the cla: yes Author has signed CLA label Apr 24, 2020
@tfds-bot tfds-bot added the community:please_review Community - We need your help to review this PR. label Apr 24, 2020
Conchylicultor
Conchylicultor requested changes Apr 24, 2020
View reviewed changes
Copy link
Member

@Conchylicultor Conchylicultor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick implementation!

tensorflow_datasets/core/lazy_imports_lib.py Outdated Show resolved Hide resolved
tensorflow_datasets/core/lazy_imports_lib.py Outdated Show resolved Hide resolved
tensorflow_datasets/core/lazy_imports_lib.py Outdated Show resolved Hide resolved
tensorflow_datasets/core/lazy_imports_lib_test.py Outdated Show resolved Hide resolved
tensorflow_datasets/core/lazy_imports_lib_test.py Outdated Show resolved Hide resolved
tensorflow_datasets/core/lazy_imports_lib_test.py Outdated Show resolved Hide resolved
tensorflow_datasets/core/lazy_imports_lib_test.py Outdated Show resolved Hide resolved
@tfds-bot tfds-bot added tfds:is_reviewing TFDS team: PTAL and removed community:please_review Community - We need your help to review this PR. labels Apr 24, 2020
@vijayphoenix
Copy link
Contributor Author

@Conchylicultor please review the changes.
Thank you

Conchylicultor
Conchylicultor requested changes Apr 26, 2020
View reviewed changes
Copy link
Member

@Conchylicultor Conchylicultor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update.

tensorflow_datasets/core/lazy_imports_lib.py Outdated Show resolved Hide resolved
tensorflow_datasets/core/lazy_imports_lib.py Outdated Show resolved Hide resolved
tensorflow_datasets/core/lazy_imports_lib.py Outdated Show resolved Hide resolved
tensorflow_datasets/core/lazy_imports_lib.py Outdated Show resolved Hide resolved
tensorflow_datasets/core/lazy_imports_lib.py Outdated Show resolved Hide resolved
tensorflow_datasets/core/lazy_imports_lib_test.py Outdated Show resolved Hide resolved
tensorflow_datasets/core/lazy_imports_lib_test.py Outdated Show resolved Hide resolved
@tfds-bot tfds-bot added author:please_respond Author - please respond to the recent comments. and removed tfds:is_reviewing TFDS team: PTAL labels Apr 26, 2020
@tfds-bot tfds-bot added tfds:is_reviewing TFDS team: PTAL and removed author:please_respond Author - please respond to the recent comments. labels Apr 27, 2020
Conchylicultor
Conchylicultor requested changes Apr 27, 2020
View reviewed changes
Copy link
Member

@Conchylicultor Conchylicultor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. This looks better.

tensorflow_datasets/core/lazy_imports_lib.py Show resolved Hide resolved
tensorflow_datasets/core/lazy_imports_lib.py Outdated Show resolved Hide resolved
tensorflow_datasets/core/lazy_imports_lib.py Outdated Show resolved Hide resolved
tensorflow_datasets/core/lazy_imports_lib.py Outdated Show resolved Hide resolved
tensorflow_datasets/core/lazy_imports_lib.py Outdated Show resolved Hide resolved
tensorflow_datasets/core/lazy_imports_lib.py Outdated Show resolved Hide resolved
@vijayphoenix vijayphoenix changed the title Add lazy_importer context manager Add try_import context manager Apr 27, 2020
@tfds-bot tfds-bot added author:please_respond Author - please respond to the recent comments. and removed tfds:is_reviewing TFDS team: PTAL labels Apr 28, 2020
@tfds-bot tfds-bot added tfds:is_reviewing TFDS team: PTAL and removed author:please_respond Author - please respond to the recent comments. labels Apr 29, 2020
Conchylicultor
Conchylicultor requested changes Apr 29, 2020
View reviewed changes
tensorflow_datasets/core/lazy_imports_lib.py Outdated Show resolved Hide resolved
tensorflow_datasets/core/lazy_imports_lib.py Outdated Show resolved Hide resolved
@tfds-bot tfds-bot added author:please_respond Author - please respond to the recent comments. and removed tfds:is_reviewing TFDS team: PTAL labels Apr 29, 2020
@tfds-bot tfds-bot added tfds:is_reviewing TFDS team: PTAL and removed author:please_respond Author - please respond to the recent comments. labels Apr 30, 2020
Conchylicultor
Conchylicultor requested changes Apr 30, 2020
View reviewed changes
Copy link
Member

@Conchylicultor Conchylicultor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

tensorflow_datasets/core/lazy_imports_lib.py Outdated Show resolved Hide resolved
tensorflow_datasets/core/lazy_imports_lib.py Outdated Show resolved Hide resolved
tensorflow_datasets/core/lazy_imports_lib.py Outdated Show resolved Hide resolved
tensorflow_datasets/core/lazy_imports_lib_test.py Show resolved Hide resolved
@tfds-bot tfds-bot added author:please_respond Author - please respond to the recent comments. and removed tfds:is_reviewing TFDS team: PTAL labels Apr 30, 2020
@tfds-bot tfds-bot added tfds:is_reviewing TFDS team: PTAL and removed author:please_respond Author - please respond to the recent comments. labels May 6, 2020
@vijayphoenix vijayphoenix added the enhancement New feature or request label Aug 3, 2020
@akihironitta akihironitta mentioned this pull request Nov 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eshan-Agarwal Eshan-Agarwal Eshan-Agarwal left review comments

@Conchylicultor Conchylicultor Awaiting requested review from Conchylicultor

Assignees
No one assigned
Labels
cla: yes Author has signed CLA enhancement New feature or request tfds:is_reviewing TFDS team: PTAL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GSoC] Better lazy_imports usability
5 participants
@vijayphoenix @Conchylicultor @Eshan-Agarwal @googlebot @tfds-bot