Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update xnli and mutli_nli checksums #2006

Merged
merged 1 commit into from May 9, 2020
Merged

Update xnli and mutli_nli checksums #2006

merged 1 commit into from May 9, 2020

Conversation

vijayphoenix
Copy link
Contributor

Fix #2004
dataset_info: https://gist.github.com/vijayphoenix/c65f04cf68ee996c41536fb94da51b4e

FYI: The datasets are already present on tfds gcs.

@googlebot googlebot added the cla: yes Author has signed CLA label May 8, 2020
@vijayphoenix vijayphoenix mentioned this pull request May 8, 2020
Closed
@tfds-bot tfds-bot added the community:please_review Community - We need your help to review this PR. label May 8, 2020
Conchylicultor
Conchylicultor approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@Conchylicultor Conchylicultor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix!

@tfds-bot tfds-bot added kokoro:run Run Kokoro tests and removed community:please_review Community - We need your help to review this PR. labels May 8, 2020
@kokoro-team kokoro-team removed the kokoro:run Run Kokoro tests label May 8, 2020
@vijayphoenix
Copy link
Contributor Author

Almost all tests failed in tf-nightly.
Was this because of some network connectivity errors?

@tfds-bot tfds-bot added the author:kokoro_test_failed Author - the kokoro tests have failed. Please check and fix the code. label May 8, 2020
@tfds-copybara tfds-copybara merged commit 1269530 into tensorflow:master May 9, 2020
@vijayphoenix vijayphoenix added tfds:ready_to_merge This PR is ready to be merged. and removed author:kokoro_test_failed Author - the kokoro tests have failed. Please check and fix the code. labels Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conchylicultor Conchylicultor Conchylicultor approved these changes

Assignees
No one assigned
Labels
cla: yes Author has signed CLA tfds:ready_to_merge This PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URL changing for XNLI and MNLI/MultiNLI
6 participants
@vijayphoenix @Conchylicultor @googlebot @kokoro-team @tfds-copybara @tfds-bot