New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use f-strings to generate dataset doc #2186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Looks good!
tensorflow_datasets/scripts/documentation/templates/dataset_doc_template.py
Outdated
Show resolved
Hide resolved
tensorflow_datasets/scripts/documentation/templates/dataset_doc_template.py
Outdated
Show resolved
Hide resolved
tensorflow_datasets/scripts/documentation/templates/dataset_doc_template.py
Outdated
Show resolved
Hide resolved
tensorflow_datasets/scripts/documentation/templates/dataset_doc_template.py
Outdated
Show resolved
Hide resolved
tensorflow_datasets/scripts/documentation/templates/dataset_doc_template.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update.
tensorflow_datasets/scripts/documentation/dataset_markdown_builder.py
Outdated
Show resolved
Hide resolved
tensorflow_datasets/scripts/documentation/dataset_markdown_builder.py
Outdated
Show resolved
Hide resolved
tensorflow_datasets/scripts/documentation/dataset_markdown_builder.py
Outdated
Show resolved
Hide resolved
tensorflow_datasets/scripts/documentation/dataset_markdown_builder.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. This looks good.
tensorflow_datasets/scripts/documentation/dataset_markdown_builder.py
Outdated
Show resolved
Hide resolved
@Conchylicultor The tests are failing because
I think this is because of the python version used for testing |
We can add dataclasses 3.6 backport to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Great work Vijay
Update catalog generation script to not use mako (stack trace harder to debug, no pylint, no syntax highlighting).