Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use f-strings to generate dataset doc #2186

Merged
merged 7 commits into from Jul 24, 2020

Conversation

vijayphoenix
Copy link
Contributor

@vijayphoenix vijayphoenix commented Jul 12, 2020

Update catalog generation script to not use mako (stack trace harder to debug, no pylint, no syntax highlighting).

@googlebot googlebot added the cla: yes Author has signed CLA label Jul 12, 2020
@tfds-bot tfds-bot added the community:please_review Community - We need your help to review this PR. label Jul 12, 2020
Copy link
Member

@Conchylicultor Conchylicultor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good!

@tfds-bot tfds-bot added author:please_respond Author - please respond to the recent comments. and removed community:please_review Community - We need your help to review this PR. labels Jul 13, 2020
@tfds-bot tfds-bot added tfds:is_reviewing TFDS team: PTAL and removed author:please_respond Author - please respond to the recent comments. labels Jul 14, 2020
Copy link
Member

@Conchylicultor Conchylicultor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update.

@tfds-bot tfds-bot added author:please_respond Author - please respond to the recent comments. and removed tfds:is_reviewing TFDS team: PTAL labels Jul 17, 2020
Copy link
Member

@Conchylicultor Conchylicultor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This looks good.

@vijayphoenix
Copy link
Contributor Author

@Conchylicultor The tests are failing because dataclasses

ImportError while importing test module '/tmpfs/src/github/datasets/tensorflow_datasets/scripts/documentation/document_datasets_test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tensorflow_datasets/scripts/documentation/document_datasets_test.py:23: in <module>
    from tensorflow_datasets.scripts.documentation import document_datasets
tensorflow_datasets/scripts/documentation/document_datasets.py:31: in <module>
    from tensorflow_datasets.scripts.documentation.dataset_markdown_builder import get_markdown_string
tensorflow_datasets/scripts/documentation/dataset_markdown_builder.py:6: in <module>
    import dataclasses
E   ModuleNotFoundError: No module named 'dataclasses'

I think this is because of the python version used for testing

@Conchylicultor
Copy link
Member

@Conchylicultor The tests are failing because dataclasses

ImportError while importing test module '/tmpfs/src/github/datasets/tensorflow_datasets/scripts/documentation/document_datasets_test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tensorflow_datasets/scripts/documentation/document_datasets_test.py:23: in <module>
    from tensorflow_datasets.scripts.documentation import document_datasets
tensorflow_datasets/scripts/documentation/document_datasets.py:31: in <module>
    from tensorflow_datasets.scripts.documentation.dataset_markdown_builder import get_markdown_string
tensorflow_datasets/scripts/documentation/dataset_markdown_builder.py:6: in <module>
    import dataclasses
E   ModuleNotFoundError: No module named 'dataclasses'

I think this is because of the python version used for testing

We can add dataclasses 3.6 backport to setup.py. Alternatively, implementing my comment #2186 (comment) will remove the need for dataclasses, as Session will be a abc.Abc instead of dataclass

@tfds-bot tfds-bot added tfds:is_reviewing TFDS team: PTAL and removed author:please_respond Author - please respond to the recent comments. labels Jul 23, 2020
Copy link
Member

@Conchylicultor Conchylicultor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Great work Vijay

@tfds-bot tfds-bot added author:kokoro_test_failed Author - the kokoro tests have failed. Please check and fix the code. and removed tfds:is_reviewing TFDS team: PTAL labels Jul 23, 2020
@tfds-copybara tfds-copybara merged commit 3ae0ecf into tensorflow:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author:kokoro_test_failed Author - the kokoro tests have failed. Please check and fix the code. cla: yes Author has signed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants