Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config_name field in dataset_info #2326

Merged
merged 2 commits into from Aug 25, 2020
Merged

Add config_name field in dataset_info #2326

merged 2 commits into from Aug 25, 2020

Conversation

vijayphoenix
Copy link
Contributor

@vijayphoenix vijayphoenix commented Aug 21, 2020 •
edited

Related to #2322 (comment)

@googlebot googlebot added the cla: yes Author has signed CLA label Aug 21, 2020
Conchylicultor
Conchylicultor requested changes Aug 21, 2020
View reviewed changes
Copy link
Member

@Conchylicultor Conchylicultor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Vijay!

tensorflow_datasets/core/dataset_info.py Outdated Show resolved Hide resolved
tensorflow_datasets/core/dataset_info.py Outdated Show resolved Hide resolved
@tfds-bot tfds-bot added the author:please_respond Author - please respond to the recent comments. label Aug 21, 2020
@tfds-bot tfds-bot added tfds:is_reviewing TFDS team: PTAL and removed author:please_respond Author - please respond to the recent comments. labels Aug 21, 2020
Conchylicultor
Conchylicultor approved these changes Aug 22, 2020
View reviewed changes
Copy link
Member

@Conchylicultor Conchylicultor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Vijay

@tfds-bot tfds-bot added tfds:ready_to_merge This PR is ready to be merged. and removed tfds:is_reviewing TFDS team: PTAL labels Aug 22, 2020
@tfds-copybara tfds-copybara merged commit c79b637 into tensorflow:master Aug 25, 2020
@Conchylicultor Conchylicultor mentioned this pull request Oct 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conchylicultor Conchylicultor Conchylicultor approved these changes

Assignees
No one assigned
Labels
cla: yes Author has signed CLA tfds:ready_to_merge This PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vijayphoenix @Conchylicultor @googlebot @tfds-copybara @tfds-bot