Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Code for Open Images and others #2479

Closed
wants to merge 4 commits into from
Closed

Cleanup Code for Open Images and others #2479

wants to merge 4 commits into from

Conversation

NikhilBartwal
Copy link
Contributor

@NikhilBartwal NikhilBartwal commented Sep 22, 2020 •
edited

@googlebot googlebot added the cla: yes Author has signed CLA label Sep 22, 2020
@NikhilBartwal NikhilBartwal changed the title Openim Cleanup Code for Open Images and others Sep 22, 2020
@tfds-bot tfds-bot added tfds:is_reviewing TFDS team: PTAL author:please_respond Author - please respond to the recent comments. and removed tfds:is_reviewing TFDS team: PTAL author:please_respond Author - please respond to the recent comments. labels Oct 2, 2020
@tfds-bot tfds-bot added author:please_respond Author - please respond to the recent comments. and removed tfds:is_reviewing TFDS team: PTAL labels Oct 5, 2020
@NikhilBartwal
Copy link
Contributor Author

@Conchylicultor The changes in the Open images dataset are compatible with the original code whereas, the paths variable in the Sun dataset was best used using the original tfds.download.resource method, which has been fixed now. I thinkl the Open Images and the Sun dataset PRs can be merged now. The inaturalist is best with the original code until we find another website to get the dataset from

@tfds-bot tfds-bot added tfds:is_reviewing TFDS team: PTAL and removed author:please_respond Author - please respond to the recent comments. labels Oct 5, 2020
@vijayphoenix
Copy link
Contributor

Closing the PR for now #2479 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conchylicultor Conchylicultor Conchylicultor requested changes

Assignees
No one assigned
Labels
cla: yes Author has signed CLA tfds:is_reviewing TFDS team: PTAL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@NikhilBartwal @vijayphoenix @Conchylicultor @googlebot @tfds-bot