Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glue/qqp data source #3031

Merged
merged 2 commits into from Jun 1, 2021

Conversation

jatin-code777
Copy link
Contributor

Fixes #3030

Unable to find the exact same data as the previous one, sized 57.73 MiB

This one has a download size of 39.76 MiB but has almost the same number of examples.

Splits Current (Old) This PR (New)
test 390,965 390,965
train 363,849 363,846
validation 40,430 40,430

Only the train seems to be missing 3 examples.

The download size reduction is probably due to the absence of the original folder in the downloaded zip.
But we don't need this folder, so it works out.

Also, I'm not sure what the version should be, since I'm unaware why it was rolled back previously.

@google-cla google-cla bot added the cla: yes Author has signed CLA label Feb 10, 2021
@tfds-bot tfds-bot added the community:please_review Community - We need your help to review this PR. label Feb 10, 2021
@vijayphoenix
Copy link
Contributor

vijayphoenix commented Feb 10, 2021

Hi @jatin-code777,
You can checkout this doc for more insight on how Datasets versioning is done.
https://www.tensorflow.org/datasets/datasets_versioning

IMO, this should be a Major/Minor version update for glue/qqp config.

@tfds-bot tfds-bot added tfds:please_review TFDS team: please review this PR. and removed community:please_review Community - We need your help to review this PR. labels Feb 16, 2021
@yurakuratov
Copy link

Hi!
Any update on this? glue/qqp is still not available via tensorflow-datasets.

@songzy12
Copy link

+1 for this. Any updates?

@Conchylicultor
Copy link
Member

Thank you! Merging this now

@tfds-copybara tfds-copybara merged commit e60f3bd into tensorflow:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Author has signed CLA tfds:please_review TFDS team: please review this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"glue/qqp" DownloadError
8 participants