Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve usability of batch_size in as_dataset function. #651

Merged

Conversation

ChanchalKumarMaji
Copy link
Contributor

@ChanchalKumarMaji ChanchalKumarMaji commented Jun 7, 2019

Currently, in the as_dataset function, batch_size=1 won't add a batch dimension while batch_size=2 will. This is inconsistent for the users as passing the batch_size as flag will modify the tensors shape.
Sol: Have batch_size=None (default) do not return batch_dimension while batch_size=1 does.

@googlebot googlebot added the cla: yes Author has signed CLA label Jun 7, 2019
@ChanchalKumarMaji
Copy link
Contributor Author

@Conchylicultor please check.

@ChanchalKumarMaji
Copy link
Contributor Author

kokoro is giving an error.

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/tmpfs/src/github/datasets/tensorflow_datasets/__init__.py", line 46, in <module>
    from tensorflow_datasets.core import tf_compat
  File "/tmpfs/src/github/datasets/tensorflow_datasets/core/__init__.py", line 18, in <module>
    from tensorflow_datasets.core.dataset_builder import BeamBasedBuilder
  File "/tmpfs/src/github/datasets/tensorflow_datasets/core/dataset_builder.py", line 30, in <module>
    import tensorflow as tf
  File "/home/kbuilder/virtualenv/tfds_env/lib/python3.6/site-packages/tensorflow/__init__.py", line 93, in <module>
    from tensorflow_core import *
AttributeError: module 'tensorflow_core' has no attribute 'compiler'

Should I bother about it ?

@tfds-copybara tfds-copybara merged commit 4badde4 into tensorflow:master Jun 11, 2019
tfds-copybara pushed a commit that referenced this pull request Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Author has signed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants