Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update classification.ipynb #1080

Merged
merged 2 commits into from
Nov 11, 2019
Merged

Update classification.ipynb #1080

merged 2 commits into from
Nov 11, 2019

Conversation

RichaldoElias
Copy link
Contributor

No description provided.

@tfdocsbot
Copy link
Collaborator

Preview and run these notebook edits with Google Colab:

Notebook diffs available on ReviewNB.com.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no CLA has not been signed label Oct 4, 2019
@@ -22,7 +22,7 @@
"outputs": [],
"source": [
"#@title Licensed under the Apache License, Version 2.0 (the \"License\");\n",
"# you may not use this file except in compliance with the License.\n",
"# You may not use this file except in compliance with the License.\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change the license. This is how they apply it: https://www.apache.org/licenses/LICENSE-2.0#apply

@@ -960,7 +960,7 @@
},
"outputs": [],
"source": [
"image_gen = ImageDataGenerator(rescale=1./255, zoom_range=0.5)"
"image_gen = ImageDataGenerator(rescale=1./255, zoom_range=0.5) # zoom_range from 0 - 1 where 1 = 100"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is narrative doc, can you add this to the text section above to make this clearer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sure

Corrected the licence text,
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes CLA has been signed and removed cla: no CLA has not been signed labels Oct 5, 2019
Copy link
Member

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tfdocsbot tfdocsbot added kokoro:force-run lgtm Community-added approval labels Nov 10, 2019
@MarkDaoust MarkDaoust added the ready to pull Start merge process label Nov 10, 2019
TensorFlow-Docs-Copybara pushed a commit that referenced this pull request Nov 11, 2019
@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit e3ed192 into tensorflow:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA has been signed lgtm Community-added approval ready to pull Start merge process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants