Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text_classification_rnn.py: Add mandatory padded_shapes argument in padded_batch #1486

Closed
wants to merge 1 commit into from

Conversation

nalepae
Copy link
Contributor

@nalepae nalepae commented Mar 3, 2020

No description provided.

@tfdocsbot
Copy link
Collaborator

Preview and run these notebook edits with Google Colab:

Notebook diffs available on ReviewNB.com.

@googlebot googlebot added the cla: yes CLA has been signed label Mar 3, 2020
@MarkDaoust
Copy link
Member

Hi @nalepae,

Thanks for the PR.

I did this in preparation for the 2.2, where the new default behavior is sufficient for these examples.

This notebook has a pip install tf-nightly at the top, so that it runs in Colab.

But I recognize that this is causing some confusion. Maybe I did it a little early. But the 2.2 branch is cut, and will be in rc soon.

If I accept this PR, I'll just have to come back and undo it at release.

So I rather keep it as is.

Thanks again.

@MarkDaoust MarkDaoust closed this Mar 3, 2020
@nalepae
Copy link
Contributor Author

nalepae commented Mar 3, 2020 via email

TensorFlow-Docs-Copybara pushed a commit that referenced this pull request Mar 19, 2020
The `tf-nightly` usage is causing a lot of confusion.
Adding a note explaining the difference and that the simplified form is only available in tf2.2.

Fixes tensorflow/tensorflow#37713
See also: #1301, #1414, #1415, #1465, #1485, #1486, #1505, #1506, #1507

PiperOrigin-RevId: 301834298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA has been signed
Projects
None yet
4 participants