Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix args of padded_batch #1415

Closed
wants to merge 1 commit into from
Closed

Conversation

baituhuangyu
Copy link
Contributor

As padded_batch needs two args: batch_size, padded_shapes, and padded_shapes=([-1], []) here.
Thank you !

As padded_batch  needs two args: batch_size, padded_shapes, and padded_shapes=([-1], []) here.
Thank you !
@tfdocsbot tfdocsbot added translation Community-provided translation for certain languages zh-cn labels Jan 20, 2020
@tfdocsbot
Copy link
Collaborator

Preview and run these notebook edits with Google Colab:

Notebook diffs available on ReviewNB.com.

@tfdocsbot
Copy link
Collaborator

Reviewers added, please take a look.
@kuri-leo, @JayYip, @yantaozhao, @loveunk, @Wind2esg, @tigerneil, @MofiiTech, @gaoljhy, @Mr-Linus, @flopsySong, @echosun1996

When your review is finished, approve the pull request or include "LGTM" in your comment.

@googlebot googlebot added the cla: yes CLA has been signed label Jan 20, 2020
@lamberta
Copy link
Member

Thanks, @baituhuangyu
Notebook translations should follow the source-of-truth docs in the en/ directory. Can you also update this notebook? https://github.com/tensorflow/docs/blob/master/site/en/tutorials/load_data/text.ipynb

@lamberta lamberta added awaiting-technical-review invalid This doesn't seem right labels Jan 21, 2020
@lamberta
Copy link
Member

Thank you.

Community translations are now located in the tensorflow/docs-l10n repo (see this message for context).

I'll move over/duplicate existing pull requests as I find time. In the meantime, please feel free to create a new pull request in that repo 😀 Then you can close this PR and add a link to the new one.

@lamberta
Copy link
Member

Fixed in https://github.com/tensorflow/docs/blob/master/site/en/tutorials/load_data/text.ipynb and this PR is no longer necessary. Thanks

@lamberta lamberta closed this Feb 28, 2020
TensorFlow-Docs-Copybara pushed a commit that referenced this pull request Mar 19, 2020
The `tf-nightly` usage is causing a lot of confusion.
Adding a note explaining the difference and that the simplified form is only available in tf2.2.

Fixes tensorflow/tensorflow#37713
See also: #1301, #1414, #1415, #1465, #1485, #1486, #1505, #1506, #1507

PiperOrigin-RevId: 301834298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-technical-review cla: yes CLA has been signed invalid This doesn't seem right translation Community-provided translation for certain languages zh-cn
Projects
None yet
4 participants