Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zh-cn_js_tutorials_index.md #635

Conversation

Projects
None yet
6 participants
@wenjinglee1104
Copy link
Contributor

commented Jun 4, 2019

No description provided.

@tfdocsbot

This comment has been minimized.

Copy link
Collaborator

commented Jun 4, 2019

Reviewers added, please take a look.
@kuri-leo

When your review is finished, approve the pull request or include "LGTM" in your comment.

Show resolved Hide resolved site/zh-cn/js/tutorials/index.md Outdated
Show resolved Hide resolved site/zh-cn/js/tutorials/index.md Outdated
Show resolved Hide resolved site/zh-cn/js/tutorials/index.md Outdated
Show resolved Hide resolved site/zh-cn/js/tutorials/index.md Outdated
Update site/zh-cn/js/tutorials/index.md
Co-Authored-By: kurileo <twkuri@gmail.com>
@googlebot

This comment has been minimized.

Copy link

commented Jun 5, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Jun 5, 2019

wenjinglee1104 and others added some commits Jun 5, 2019

Update site/zh-cn/js/tutorials/index.md
Co-Authored-By: kurileo <twkuri@gmail.com>
Update site/zh-cn/js/tutorials/index.md
Co-Authored-By: kurileo <twkuri@gmail.com>
Update site/zh-cn/js/tutorials/index.md
Co-Authored-By: kurileo <twkuri@gmail.com>
@kuri-leo
Copy link
Contributor

left a comment

LGTM

@lamberta
Copy link
Member

left a comment

Thank you both for the contribution and review
I've verified the CLAs for all committers

@lamberta lamberta added cla: yes and removed cla: no labels Jun 5, 2019

@googlebot

This comment has been minimized.

Copy link

commented Jun 5, 2019

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit 2846921 into tensorflow:master Jun 5, 2019

2 checks passed

cla/google CLAs have been manually verified by Googler who has set the 'cla: yes' label
import/copybara Change imported to the internal review system
Details

TensorFlow-Docs-Copybara pushed a commit that referenced this pull request Jun 5, 2019

Copybara-Service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.