Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App screenshot added to Image classification android example #329

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

SunitRoy2703
Copy link
Contributor

added and shown the App screenshot of the Image classification android example

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Jun 27, 2021
@google-cla google-cla bot added the cla: yes CLA has been signed label Jun 27, 2021
@@ -17,7 +17,8 @@ These instructions walk you through building and running the demo on an Android
device. For an explanation of the source, see
[TensorFlow Lite Android image classification example](EXPLORE_THE_CODE.md).

<!-- TODO(b/124116863): Add app screenshot. -->
<img src= https://github.com/SunitRoy2703/examples/raw/image-classification-android-screenshot/lite/examples/image_classification/android/screenshot.png width="350" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to add an image.

Please use:
src="https://www.tensorflow.org/lite/examples/image_classification/images/android_banana.png"

Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reviewing @lintian06
I have removed the image and changed the image src to "https://www.tensorflow.org/lite/examples/image_classification/images/android_banana.png"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please surround src with "". Thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @lintian06
I have added image src with "" surrounding it.

@@ -17,7 +17,8 @@ These instructions walk you through building and running the demo on an Android
device. For an explanation of the source, see
[TensorFlow Lite Android image classification example](EXPLORE_THE_CODE.md).

<!-- TODO(b/124116863): Add app screenshot. -->
<img src= "https://www.tensorflow.org/lite/examples/image_classification/images/android_banana.png" width="350" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the space

Copy link
Contributor

@lintian06 lintian06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to the PR!

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull labels Jun 29, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 29, 2021
@SunitRoy2703
Copy link
Contributor Author

Thank you for contributing to the PR!

my pleasure!

@jdduke jdduke removed their request for review June 29, 2021 22:52
@SunitRoy2703
Copy link
Contributor Author

Any update on this? @lintian06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA has been signed ready to pull size:XS CL Change Size: Extra Small
Projects
None yet
3 participants