New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix saved_model_test: #736

Closed

copybara-service wants to merge 0 commits into main from test_587743240

copybara-service bot commented Dec 4, 2023

Fix saved_model_test:

Inject tool locations as args into the sh_test. (Old code was wrong.)
set -e -u -o pipefail to catch errors like missing tools and die.
Redefine py_binary analogously to py_test to pick up installed libraries
instead of bazel deps (because these are just //:expect_* placeholders).

copybara-service bot force-pushed the test_587743240 branch 2 times, most recently from 68bbf32 to dda7386 Compare

December 4, 2023 18:54

copybara-service bot closed this

copybara-service bot force-pushed the test_587743240 branch from dda7386 to 8151d9c Compare

December 4, 2023 19:07

copybara-service bot deleted the test_587743240 branch

December 4, 2023 19:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment