Skip to content

Commit

Permalink
Fix Docker file build failure (#988)
Browse files Browse the repository at this point in the history
This PR tries to fix issue raised in 987.

The issue seems to be related to Ubuntu 16.04 have a gcc 5.4 that is old
and does not plays well with std=c++14.
This PR adjust arrow's flag to std=c++11 to allow gcc 5.4 working again.

As python 3.5 will EOL in 09/13/2020, we might consider dropping Ubuntu 16.04
support (and issues related to gcc 5.4 + python 3.5) sometime this year.

This PR fixes 987.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
  • Loading branch information
yongtang committed May 29, 2020
1 parent 5a64b0c commit 215edac
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions third_party/arrow.BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ cc_library(
"cpp/src/arrow/util/config.h",
"cpp/src/parquet/parquet_version.h",
],
copts = ["-std=c++11"],
defines = [
"ARROW_WITH_BROTLI",
"ARROW_WITH_SNAPPY",
Expand Down
2 changes: 1 addition & 1 deletion tools/dev/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM tensorflow/tensorflow:custom-op-ubuntu16

RUN rm /etc/apt/sources.list.d/jonathonf-ubuntu-python-3_6-xenial.list && apt-get update && \
RUN rm -f /etc/apt/sources.list.d/jonathonf-ubuntu-python-3_6-xenial.list && apt-get update && \
apt-get install -y \
git \
gcc \
Expand Down

0 comments on commit 215edac

Please sign in to comment.