Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3 to Travis CI #17

Merged
merged 4 commits into from
Dec 12, 2018
Merged

Add Python 3 to Travis CI #17

merged 4 commits into from
Dec 12, 2018

Conversation

yongtang
Copy link
Member

@yongtang yongtang commented Dec 12, 2018 •
edited
Loading

Add Python 3 to Travis CI

Signed-off-by: Yong Tang yong.tang.github@outlook.com

@yongtang
Fix //tensorflow_io/hadoop:hadoop_py_test failure on Python 3
fc10234 
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@yongtang
Fix test failure for //tensorflow_io/kafka:kafka_py_test in Python 3
b75a355 
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@yongtang yongtang changed the title [WIP] Add Python 3 to Travis CI Add Python 3 to Travis CI Dec 12, 2018
@yongtang
Add Python 3 to Travis CI
fbe4395 
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@yongtang
Copy link
Member Author

The Python 3 failure has been fixed. Now the following Travis CI builds have been enabled:

  • Python 2.7
  • Python 3.4
  • Python 3.5
  • Python 3.6
  • R

@yongtang yongtang mentioned this pull request Dec 12, 2018
Closed
terrytangyuan
terrytangyuan reviewed Dec 12, 2018
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but perhaps move the repetitive code into a separate script?

@yongtang
Move Travis CI related script to .travis/
53e2e6d 
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@yongtang
Copy link
Member Author

The PR has been updated.

terrytangyuan
terrytangyuan approved these changes Dec 12, 2018
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yongtang yongtang merged commit 6d82ea3 into tensorflow:master Dec 12, 2018
@yongtang yongtang deleted the python3 branch December 12, 2018 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yongtang @terrytangyuan