Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Python 3.7 build #193

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Conversation

yongtang
Copy link
Member

Think I managed to make python 3.7 build working.

/cc @terrytangyuan @BryanCutler @dmitrievanthony

Signed-off-by: Yong Tang yong.tang.github@outlook.com

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@BryanCutler
Copy link
Member

Nice work @yongtang ! The 50 min limit seems to be a real problem now..

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@terrytangyuan terrytangyuan merged commit 7facfc5 into tensorflow:master Apr 17, 2019
@yongtang yongtang deleted the python3.7 branch April 17, 2019 15:34
@yongtang
Copy link
Member Author

@BryanCutler Yes it is concerning as we are gradually reaching 50min. Something may have to be done soon. Another factor to take into consideration is the upcoming tf 1.14 release. I think we may be able to do something once 1.14 is out, see if we could get help from Kokorun(Google C).

@yongtang
Copy link
Member Author

At the moment, the biggest chunk of the time is the C++ code compile which is close to 25-30 minutes. Other than that, we have Ignite/Kafka/Kinesis/PubSub setup for about 10 minutes. Kind of hard to optimize with Travis CI.

@yongtang yongtang mentioned this pull request May 9, 2019
i-ony pushed a commit to i-ony/io that referenced this pull request Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants