-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libsvm dataset support #32
Conversation
Overall looks good, though I am wondering if we could expose a class interface such as |
it is hard, since we only have a parsing kernel for now, we need to implement a datasource kernel to support that basically. if it is really worth it, i can make a second pr to port current paring kernel into datasource kernel and the function pattern is also from tensorflow core https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/data/experimental/ops/readers.py#L311 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I think this is good. We could consider adding DatasetSource support later. LGTM
* feat: reading from bigtable (#2) Implements reading from bigtable in a synchronous manner. * feat: RowRange and RowSet API. * feat: parallel read (#4) In this pr we make the read methods accept a row_set reading only rows specified by the user. We also add a parallel read, that leverages the sample_row_keys method to split work among workers. * feat: version filters (#6) This PR adds support for Bigtable version filters. * feat: support for other data types (#5) * fix: linter fixes (#8) * feat docs (#9) * fix: building on windows (#12) * fix: refactor bigtable package to api folder (#14) moved bigtable to tfensorflow_io.python.api * fix: tests hanging (#30) changed path to bigtable emulator and cbt in tests moved arguments' initializations to the body of the function in bigtable_ops.py fixed interleaveFromRange of column filters when using only one column * fix: temporarily disable macos tests (#32) * disable tests on macos Co-authored-by: Kajetan Boroszko <kajetan@unoperate.com> Co-authored-by: Kajetan Boroszko <kajetan.boroszko@gmail.com>
Address #10
add
make_libsvm_dataset
function, which returns a dataset contains (feature, label) per row.