Change to float32 for AudioIOTensor and AudioIODataset in case of MP3 and Ogg #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
terrytangyuan
approved these changes
Mar 17, 2020
i-ony
pushed a commit
to i-ony/io
that referenced
this pull request
Feb 8, 2021
… and Ogg (tensorflow#859) * Use float for ogg as ogg is lossy anyway Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Change to float32 for AudioIOTensor and AudioIODataset in case of MP3 Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to float32 for AudioIOTensor and AudioIODataset in case of MP3 and Ogg, and make related changes to
decode_ogg.This is related to discussion to #839 (comment)
Note
decode_mp3is not in place yet. I will defer to #815 for now. May pick up if needed.Signed-off-by: Yong Tang yong.tang.github@outlook.com