Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move package_config.py into dir #225

Conversation

calvinleungyk
Copy link
Contributor

No description provided.

@codesue codesue reopened this Nov 9, 2022
@codesue
Copy link
Collaborator

codesue commented Nov 9, 2022

Hey @calvinleungyk, thanks for your work on this PR! 🙌

I reopenned it because we'd like to enable generating MCT protos and building a wheel. This looks good to me, and I think we can merge it after reverting changes to setup.py. The tfx dependency will be removed entirely in #237.

@codesue codesue changed the base branch from master to codesue/staging November 10, 2022 12:41
@codesue
Copy link
Collaborator

codesue commented Nov 10, 2022

Merging to a different branch first to make changes.

@codesue codesue merged commit e1b4f71 into tensorflow:codesue/staging Nov 10, 2022
@codesue codesue mentioned this pull request Nov 10, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants