-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wheel release workflow #238
Conversation
…build Add workflow to generate protos and build wheel
@codesue thank you for the awesome PR! Since we can push every version only once to PyPI, let's the lining and testing steps to the PR. The repo contains the workflows for What do you think? |
Indeed. However note that MCT requires a bit more complexity when it comes to building it's wheel. We may want to clean it after. Also Sue for now, we may want to just add everything after https://github.com/tensorflow/tfx-addons/blob/18274a7ee395f51bb89490dce33885aa16b98446/.github/workflows/release.yml#L31 into the workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can iterate on this
|
name: Build Model Card Toolkit package and release to PyPI and Test PyPI | ||
runs-on: ubuntu-latest | ||
container: | ||
image: gcr.io/tfx-oss-public/tfx_base:py37-20200729 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codesue This is very nit, so apologies. Do we need to the tfx-base
image here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image was convenient because it has the right versions of the tools need to build the wheel, e.g. bazel. It's used to build tfx wheels, which have similar build steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, perfect! Thank you for the explanation @codesue!
Description
This pull request adds:
model-card-toolkit
wheel on release and publishes it to PyPI and TestPyPIzlib
archive location to prevent Bazel commands from failing with not found errors (see https://zlib.net/zlib-1.2.11.tar.gz Not Found bazelbuild/bazel#15136)These workflows and release process were adapted from those in tfx-addons.
I tested the changes by triggering the workflow on pull request:
Checklist
Before submitting a pull request, please be sure to do the following: