Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added gitignore to repo #240

Merged
merged 3 commits into from
Nov 12, 2022

Conversation

hanneshapke
Copy link
Collaborator

@hanneshapke hanneshapke commented Nov 12, 2022

Description

Seems like the repo was missing a gitignore file since it was a copy from the internal git repo at Google.

related #241

Checklist

Before submitting a pull request, please be sure to do the following:

  • Read the How to Contribute guide
    if this is your first contribution.
  • Open an issue to discuss this change.
  • Update documentation if applicable.
  • Write new tests if applicable.

@codesue
Copy link
Collaborator

codesue commented Nov 12, 2022

Thanks for adding this! I'd prefer using GitHub's Python gitignore as the base since it's more commonly used and doesn't require attribution. From there, we can add:

# VSCode project settings
.vscode

# Bazel generated files
bazel-*
**/*_pb2.py
**/*_pb2_grpc.py

And change

*.py[cod]
*$py.class

# C extensions
*.so

to

**/*.py[cod]
**/*$py.class

# C extensions
**/*.so

This is similar to tfx/.gitignore but with more recent changes to GitHub's Python base incorporated.

@hanneshapke
Copy link
Collaborator Author

Thank you @codesue for your feedback. I updated the gitignore file.

.gitignore Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@hanneshapke hanneshapke merged commit 54b1fd5 into tensorflow:master Nov 12, 2022
@hanneshapke hanneshapke deleted the hannes/update-gitignore branch November 12, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants