Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve TODO for distutils migration as not applicable #290

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

codesue
Copy link
Collaborator

@codesue codesue commented Jul 15, 2023

What does this pull request do?

Resolves the TODO to migrate setup.py from distutils to setuptools since it's not applicable. There isn't a good setuptools alternative yet for distutils.command.build, and we can continue to use distutils through setuptools' bundled copy after it's removed from the standard library. See pypa/setuptools#2928.

Fixes #269

How did you test this change?

n/a

How did you document this change?

n/a

Before submitting

Before submitting a pull request, please be sure to do the following:

  • Read the How to Contribute guide if this is your first contribution.
  • Open an issue or discussion topic to discuss this change.
  • Write new tests if applicable.
  • Update documentation if applicable.

Copy link
Collaborator

@rcrowe-google rcrowe-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codesue codesue merged commit 45d3d4c into tensorflow:main Jul 17, 2023
4 checks passed
@codesue codesue deleted the codesue/distutils-fix branch July 19, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate setup.py from distutils to setuptools
2 participants