Adding LARS to ResNet #6327
Merged
Adding LARS to ResNet #6327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robieta
reviewed
Mar 8, 2019
dubey
reviewed
Mar 8, 2019
| for batch size). The learning rate is then decayed using a polynomial rate | ||
| decay schedule with power 2.0. | ||
|
|
||
| Args: |
robieta
reviewed
Mar 8, 2019
official/resnet/imagenet_main.py
Outdated
| @@ -44,6 +44,19 @@ | |||
|
|
|||
| DATASET_NAME = 'ImageNet' | |||
|
|
|||
| flags.DEFINE_bool('enable_lars', | |||
There was a problem hiding this comment.
Can you move these into define_resnet_flags in resnet_run_loop.py?
tfboyd
requested changes
Mar 8, 2019
There was a problem hiding this comment.
When you are finished with all the comments make sure you fix the lint errors we cleaned them all up and do not want to add new ones. You can see the errors by clicking the link that will take you to sponge. The log is hard to read but it tells you lines,files, and reasons.
tfboyd
approved these changes
Mar 8, 2019
robieta
suggested changes
Mar 9, 2019
| returns the current learning rate | ||
| """ | ||
|
|
||
| # Learning rate schedule for LARS polynomial schedule |
There was a problem hiding this comment.
I think this is different from before. Shouldn't it be:
if flags.FLAGS.batch_size < 8192:
plr = 5.0
w_epochs = 5
elif flags.FLAGS.batch_size < 16384:
plr = 10.0
w_epochs = 5
if flags.FLAGS.batch_size < 32768:
plr = 25.0
w_epochs = 5
else:
plr = 32.0
w_epochs = 14
robieta
approved these changes
Mar 9, 2019
|
Thanks! Enjoy the big shiny green button. |
wlongxiang
pushed a commit
to wlongxiang/models
that referenced
this pull request
Apr 24, 2019
* Adding LARS to ResNet * Fixes for the LARS patch * Fixes for the LARS patch * more fixes * 1 more fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding LARS to ResNet