Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement serialization logic for ProjectorSums. #623

Merged
merged 10 commits into from
Nov 18, 2021
Merged

Implement serialization logic for ProjectorSums. #623

merged 10 commits into from
Nov 18, 2021

Conversation

tonybruguier
Copy link
Contributor

This is step 2 of issue #357

@tonybruguier tonybruguier mentioned this pull request Aug 22, 2021
Merged
CirqBot pushed a commit to quantumlib/Cirq that referenced this pull request Aug 22, 2021
@tonybruguier
Add missing code for ProjectorSum serialization in TFQ (#4456)
1c2eafb 
For issue #3288 I noticed that some code was missing when working on integrating with TFQ:
tensorflow/quantum#623
MichaelBroughton
MichaelBroughton reviewed Aug 26, 2021
View reviewed changes
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great first pass! Hopefully we can get #621 in soon to unblock this.

tensorflow_quantum/core/proto/projector_sum.proto Outdated Show resolved Hide resolved
@tonybruguier
Copy link
Contributor Author

Thanks, @MichaelBroughton

However, having #621 merged will not be sufficient because version 0.12.0 doesn't contain:
quantumlib/Cirq#4456
and
quantumlib/Cirq#4364

However, I am testing my code locally now, with both Cirq and TFQ at head. So hopefully, this will be ready once Cirq 0.13.0 is released.

I do plan to continue working on #621 though. Not to unblock this PR, but maybe to avoid getting too much behind?

@tonybruguier tonybruguier marked this pull request as ready for review November 2, 2021 14:08
@tonybruguier
Copy link
Contributor Author

@MichaelBroughton
Thanks for merging #621. The present PR can now be reviewed, I think and if you have the time, because its unit tests now pass.

@tonybruguier
Copy link
Contributor Author

Friendly ping. I could work on this over the Thanksgiving break if you have more comments.

MichaelBroughton
MichaelBroughton previously approved these changes Nov 17, 2021
View reviewed changes
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after some nits. This is great, sorry again for the slow review.

tensorflow_quantum/core/serialize/serializer.py Outdated Show resolved Hide resolved
tensorflow_quantum/core/serialize/serializer.py Outdated Show resolved Hide resolved
tensorflow_quantum/core/serialize/serializer_test.py Show resolved Hide resolved
@MichaelBroughton MichaelBroughton merged commit 09ba5d3 into tensorflow:master Nov 18, 2021
@tonybruguier tonybruguier deleted the tfq_serialize_proj branch November 18, 2021 13:30
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@tonybruguier @rht
Add missing code for ProjectorSum serialization in TFQ (quantumlib#4456)
f696d40 
For issue quantumlib#3288 I noticed that some code was missing when working on integrating with TFQ:
tensorflow/quantum#623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelBroughton MichaelBroughton MichaelBroughton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tonybruguier @MichaelBroughton