(WIP) Tensorflow gpu dependency with supporting Dockerfile #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davemssavage
changed the title
|
Thanks for working on this, @davemssavage ! The dockerfiles look great for automating the install process. The steps outlined are similar to what is outlined in the README. We will leave it up to the user for now to write their custom dockerfiles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this probably shouldn't be a pull request yet, more a point of conversation as it's pretty experimental having hardcoded the gpu dependency in the setup file and the Docker file.
I can add variants for the Docker file if it's something you want to accept however I've not used bazel much so was wondering on the best way to tackle the gpu dependency - happy to take advice and update this patch further if you think gpu support will be of use.