Add metrics to the Prometheus API #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qisikai
previously approved these changes
May 10, 2020
|
It's been two weeks now, could you please confirm this? |
|
@netfs Please check and merge this PR? |
|
please do look at c317582 that adds runtime (latency) metrics for predict/regress/classify methods (and these are exported as prometheus metrics, if you enable prometheus export). the above commit does not include latency stats for rpc/http handling, and thats where your PR would be useful. |
netfs
reviewed
Dec 8, 2020
Conflicts: tensorflow_serving/model_servers/http_rest_api_handler.cc tensorflow_serving/servables/tensorflow/util.cc tensorflow_serving/servables/tensorflow/util.h
|
@netfs I fixed. |
netfs
reviewed
Jan 5, 2021
|
@netfs I fixed. |
netfs
reviewed
Jan 11, 2021
netfs
reviewed
Jan 11, 2021
There was a problem hiding this comment.
also please fix broken test:
https://source.cloud.google.com/results/invocations/efea5490-a7cc-4556-a1ac-115b7c25a0d9/targets
netfs
reviewed
Jan 19, 2021
netfs
reviewed
Jan 19, 2021
netfs
requested changes
Jan 20, 2021
|
Will merge shortly. |
|
Sorry, I fixed test. (I don't know the command to run unit tests in my development environment.) |
netfs
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
This patch adds latency and availability metrics for Predict method in gRPC API to the Prometheus API.
The metrics are measured for the entire process and for each model.
The added metric items are as follows.