Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move bert demo to examples namespace #319

Closed
wants to merge 3 commits into from

Conversation

brettkoonce
Copy link
Contributor

fixes import warnings, eg "'TensorFlowModels' /home/skoonce/swift-models: warning: ignoring duplicate product 'TextModels'"

Copy link
Contributor

@saeta saeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @brettkoonce ! This is really great.

Package.swift Outdated Show resolved Hide resolved
@BradLarson
Copy link
Contributor

I think we may have collided here, because I did the same with PR #321 that I just submitted. I had been working on a larger reorganization of the model so that the dataset and an example like the above could be extracted. I made a few more elaborate changes to the overall structure as a first step so that we can remove some duplicate code and reuse some of this in the Transformer example.

I liked your phrasing better in your Readme, so I used that for the text in the BERT-CoLA Readme I submitted as part of my pull request. Thanks for writing that up.

Sorry for not making it clear that I was working on this. If you'd prefer to have your PR landed first, I think I can rework mine to be a follow-on to yours.

@brettkoonce
Copy link
Contributor Author

nbd, carry on!

@BradLarson
Copy link
Contributor

Thanks, again sorry about that. Appreciate the cleanup work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants