This repository has been archived by the owner on Jul 7, 2023. It is now read-only.
Fixes Universal Transformer not converging bug #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rllin-fathom
changed the title
|
Hi @rllin-fathom, Thanks for the PR! |
|
Thanks to both @rllin-fathom and @MostafaDehghani -- I can take both the PRs :) Will merge in both of them shortly. Many thanks to both of you for fixing this the right way! |
tensorflow-copybara
pushed a commit
that referenced
this pull request
Nov 1, 2018
PiperOrigin-RevId: 219664613
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue discussed in #1191