This repository has been archived by the owner on Jul 7, 2023. It is now read-only.
Fixes UT convergence problem (issue discussed in #1191) #1194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the default for "use_memory_as_final_state" flag to False.
Removed the undefined/reduntant flag "use_memory_as_last_state".
NOTE: PR #1192 submitted by @rllin-fathom is basically addressing the same issue, but here I also added the condition of using memory as the final state only when the transition function is an LSTM (to avoid unintentional use of memory for other transition functions).