LSC — Explicitly mark AOT incompatible targets via 'jit:true'

tensorflow · Jul 25, 2024 · b25a3b4 · b25a3b4
1 parent a34563c
commit b25a3b4
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 2 deletions.
diff --git a/tensorboard/webapp/app_routing/effects/app_routing_effects_test.ts b/tensorboard/webapp/app_routing/effects/app_routing_effects_test.ts
@@ -48,7 +48,7 @@ import {
 } from '../types';
 import {AppRoutingEffects, TEST_ONLY} from './app_routing_effects';
 
-@Component({selector: 'test', template: ''})
+@Component({selector: 'test', template: '', jit: true})
 class TestableComponent {}
 
 const testAction = createAction('[TEST] test action');

diff --git a/tensorboard/webapp/feature_flag/views/feature_flag_modal_trigger_container_test.ts b/tensorboard/webapp/feature_flag/views/feature_flag_modal_trigger_container_test.ts
@@ -37,6 +37,7 @@ import {
 @Component({
   selector: 'testable-feature-flag-dialog-container',
   template: '<div>Test</div>',
+  jit: true,
 })
 class TestableFeatureFlagDialogContainer {}
 

diff --git a/tensorboard/webapp/plugins/testing/index.ts b/tensorboard/webapp/plugins/testing/index.ts
@@ -26,5 +26,6 @@ export class ExtraDashboardComponent {}
   imports: [
     PluginRegistryModule.forPlugin('extra-plugin', ExtraDashboardComponent),
   ],
+  jit: true,
 })
 export class ExtraDashboardModule {}
diff --git a/tensorboard/webapp/testing/integration_test_module.ts b/tensorboard/webapp/testing/integration_test_module.ts
@@ -33,6 +33,7 @@ import {MatIconTestingModule} from './mat_icon_module';
 @Component({
   selector: 'test',
   template: 'hello',
+  jit: true,
 })
 export class TestableComponent {}
 

diff --git a/tensorboard/webapp/webapp_data_source/tb_feature_flag_testing.ts b/tensorboard/webapp/webapp_data_source/tb_feature_flag_testing.ts
@@ -42,5 +42,6 @@ export class TestingTBFeatureFlagDataSource extends TBFeatureFlagDataSource {
       useExisting: TestingTBFeatureFlagDataSource,
     },
   ],
+  jit: true,
 })
 export class TBFeatureFlagTestingModule {}
diff --git a/tensorboard/webapp/webapp_data_source/tb_http_client_testing.ts b/tensorboard/webapp/webapp_data_source/tb_http_client_testing.ts
@@ -34,5 +34,6 @@ import {TBHttpClientModule} from './tb_http_client_module';
       ),
     }),
   ],
+  jit: true,
 })
 export class TBHttpClientTestingModule {}
diff --git a/tensorboard/webapp/widgets/intersection_observer/intersection_observer_testing_module.ts b/tensorboard/webapp/widgets/intersection_observer/intersection_observer_testing_module.ts
@@ -16,7 +16,7 @@ import {Directive, EventEmitter, NgModule, Output} from '@angular/core';
 import {ComponentFixture} from '@angular/core/testing';
 import {By} from '@angular/platform-browser';
 
-@Directive({selector: '[observeIntersection]'})
+@Directive({selector: '[observeIntersection]', jit: true})
 class IntersectionObserverTestingDirective {
   @Output() onVisibilityChange = new EventEmitter<{visible: boolean}>();
 
@@ -28,6 +28,7 @@ class IntersectionObserverTestingDirective {
 @NgModule({
   exports: [IntersectionObserverTestingDirective],
   declarations: [IntersectionObserverTestingDirective],
+  jit: true,
 })
 export class IntersectionObserverTestingModule {
   simulateVisibilityChange<T>(fixture: ComponentFixture<T>, visible: boolean) {

diff --git a/tensorboard/webapp/widgets/resize_detector_testing_module.ts b/tensorboard/webapp/widgets/resize_detector_testing_module.ts
@@ -29,6 +29,7 @@ class ResizeDetectorTestingDirective {
 @NgModule({
   exports: [ResizeDetectorTestingDirective],
   declarations: [ResizeDetectorTestingDirective],
+  jit: true,
 })
 export class ResizeDetectorTestingModule {
   simulateResize<T>(fixture: ComponentFixture<T>) {