Removing a Fob triggers a Time Selection Changed Event #5968
Assignees
Labels
Comments
rileyajones
added
type:bug
plugin:time-series
javascript
rileyajones
added a commit
that referenced
this issue
Oct 18, 2022
…b is removed (#5976) ## Motivation for features / changes #5968 ## Technical description of changes The card fob would dispatch a `timeSelectionChanged` event on mouse up even if the time selection had not changed... ## Detailed steps to verify changes work correctly (as executed by you) 1) Start tensorboard 2) Go to http://localhost:6006 3) Enable step selection 4) Open the console and clear it 5) Dismiss the fob by clicking this button  ## Alternate designs / implementations considered Add a `mousedown` event listener to the dismiss button which prevents propagation. Unfortunately this would prevent clicks starting on the dismiss button from dragging the fob.
qihach64
pushed a commit
to qihach64/tensorboard
that referenced
this issue
Dec 19, 2022
…b is removed (tensorflow#5976) ## Motivation for features / changes tensorflow#5968 ## Technical description of changes The card fob would dispatch a `timeSelectionChanged` event on mouse up even if the time selection had not changed... ## Detailed steps to verify changes work correctly (as executed by you) 1) Start tensorboard 2) Go to http://localhost:6006 3) Enable step selection 4) Open the console and clear it 5) Dismiss the fob by clicking this button  ## Alternate designs / implementations considered Add a `mousedown` event listener to the dismiss button which prevents propagation. Unfortunately this would prevent clicks starting on the dismiss button from dragging the fob.
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this issue
Mar 27, 2023
…b is removed (tensorflow#5976) ## Motivation for features / changes tensorflow#5968 ## Technical description of changes The card fob would dispatch a `timeSelectionChanged` event on mouse up even if the time selection had not changed... ## Detailed steps to verify changes work correctly (as executed by you) 1) Start tensorboard 2) Go to http://localhost:6006 3) Enable step selection 4) Open the console and clear it 5) Dismiss the fob by clicking this button  ## Alternate designs / implementations considered Add a `mousedown` event listener to the dismiss button which prevents propagation. Unfortunately this would prevent clicks starting on the dismiss button from dragging the fob.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this issue
May 1, 2023
…b is removed (tensorflow#5976) ## Motivation for features / changes tensorflow#5968 ## Technical description of changes The card fob would dispatch a `timeSelectionChanged` event on mouse up even if the time selection had not changed... ## Detailed steps to verify changes work correctly (as executed by you) 1) Start tensorboard 2) Go to http://localhost:6006 3) Enable step selection 4) Open the console and clear it 5) Dismiss the fob by clicking this button  ## Alternate designs / implementations considered Add a `mousedown` event listener to the dismiss button which prevents propagation. Unfortunately this would prevent clicks starting on the dismiss button from dragging the fob.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue description
This happens because there is click event is bound to the card_fob_component
AND a mousedown event bound to the card_fob_controller_component
Before
After
Action
cast.webm
The text was updated successfully, but these errors were encountered: