Bug Fix: Prevent Card Fob from dispatching duplicate events when a fob is removed #5976
Conversation
Do we actually want to fire a |
Not a huge deal but, yea I think we would want to log the metric that they dragged the fob around. If the user drags the fob around...checks out some values and then moves it back to starting position I would want to track that in our metrics as a change. |
That makes sense, it should work that way now |
…b is removed (tensorflow#5976) ## Motivation for features / changes tensorflow#5968 ## Technical description of changes The card fob would dispatch a `timeSelectionChanged` event on mouse up even if the time selection had not changed... ## Detailed steps to verify changes work correctly (as executed by you) 1) Start tensorboard 2) Go to http://localhost:6006 3) Enable step selection 4) Open the console and clear it 5) Dismiss the fob by clicking this button  ## Alternate designs / implementations considered Add a `mousedown` event listener to the dismiss button which prevents propagation. Unfortunately this would prevent clicks starting on the dismiss button from dragging the fob.
…b is removed (tensorflow#5976) ## Motivation for features / changes tensorflow#5968 ## Technical description of changes The card fob would dispatch a `timeSelectionChanged` event on mouse up even if the time selection had not changed... ## Detailed steps to verify changes work correctly (as executed by you) 1) Start tensorboard 2) Go to http://localhost:6006 3) Enable step selection 4) Open the console and clear it 5) Dismiss the fob by clicking this button  ## Alternate designs / implementations considered Add a `mousedown` event listener to the dismiss button which prevents propagation. Unfortunately this would prevent clicks starting on the dismiss button from dragging the fob.
…b is removed (tensorflow#5976) ## Motivation for features / changes tensorflow#5968 ## Technical description of changes The card fob would dispatch a `timeSelectionChanged` event on mouse up even if the time selection had not changed... ## Detailed steps to verify changes work correctly (as executed by you) 1) Start tensorboard 2) Go to http://localhost:6006 3) Enable step selection 4) Open the console and clear it 5) Dismiss the fob by clicking this button  ## Alternate designs / implementations considered Add a `mousedown` event listener to the dismiss button which prevents propagation. Unfortunately this would prevent clicks starting on the dismiss button from dragging the fob.
Motivation for features / changes
#5968
Technical description of changes
The card fob would dispatch a
timeSelectionChangedevent on mouse up even if the time selection had not changed...Detailed steps to verify changes work correctly (as executed by you)
Alternate designs / implementations considered
Add a
mousedownevent listener to the dismiss button which prevents propagation. Unfortunately this would prevent clicks starting on the dismiss button from dragging the fob.