Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when logdir/db not given. #1189

Merged
merged 2 commits into from
May 16, 2018

Conversation

oxinabox
Copy link
Contributor

I can never remember what the actual argument for logdir is.
Is it tensorboard ./logs/ ?
Is it tensorboard --logdir ./logs/ ?
Is it tensorboard --log-dir ./logs/ ?

I feel like putting in an example just makes it really obvious.

Also with the version I am using (1.7),
tensorboard --help gives no useful information on this argument, so when it needed for details and examples is tensorboard --helpfull.

I can never remember what the actual argument for logdir is.
Is it `tensorboard ./logs/`  ? 
Is it `tensorboard --logdir ./logs/` ?
Is it `tensorboard --log-dir ./logs/` ?

I feel like putting in an example just makes it really obvious.

Also with the version I am using (1.7),
`tensorboard --help` gives no useful information on this argument, so when it needed for details and examples is `tensorboard --helpfull`.
@nfelt nfelt self-requested a review May 16, 2018 19:33
Copy link
Contributor

@nfelt nfelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement!

@nfelt nfelt merged commit d0de54e into tensorflow:master May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants