manager: add I/O for TensorboardInfo files #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wchargin
force-pushed
the
wchargin-tensorboardinfo-io
branch
from
7778678
to
3f594d6
Compare
wchargin
commented
Feb 5, 2019
wchargin
force-pushed
the
wchargin-tensorboardinfo-io
branch
from
3f594d6
to
f0884e6
Compare
wchargin
force-pushed
the
wchargin-cache-key-str
branch
from
762203f
to
62620dc
Compare
wchargin
force-pushed
the
wchargin-tensorboardinfo-io
branch
from
f0884e6
to
311af09
Compare
wchargin
force-pushed
the
wchargin-tensorboardinfo-io
branch
from
311af09
to
5216432
Compare
stephanwlee
reviewed
Feb 6, 2019
wchargin
force-pushed
the
wchargin-tensorboardinfo-io
branch
2 times, most recently
from
4a4ed31
to
c62bcaa
Compare
stephanwlee
approved these changes
Feb 6, 2019
|
@manivaradarajan, would you like me to wait for your review before |
Summary: This commit implements functions `write_info_file`, `remove_info_file`, and `get_all` on the `tensorboard.manager` module. See docs for details. Supersedes part of #1795. Test Plan: Integration tests included; run `bazel test //tensorboard:manager_test`. wchargin-branch: tensorboardinfo-io
wchargin-branch: tensorboardinfo-io
Test Plan: Fingers crossed (haven’t run locally; will see what Travis thinks). wchargin-branch: tensorboardinfo-io
wchargin
force-pushed
the
wchargin-tensorboardinfo-io
branch
from
c62bcaa
to
41b4625
Compare
wchargin
added a commit
that referenced
this pull request
Feb 6, 2019
Summary: This commit wires up `TensorBoard.main` to the `TensorboardInfo` I/O introduced in #1806. Test Plan: Run `bazel run //tensorboard -- --logdir ./whatever/`, then verify that an info file has been created… $ ls /tmp/.tensorboard-info/ pid-85532.info …and that the file is visible to the Python APIs: $ python >>> from tensorboard import manager >>> infos = manager.get_all() >>> len(infos) 1 >>> infos[0].pid 85532 >>> infos[0].port 6006 Then, SIGTERM the server and verify that this is reflected from Python… >>> import os >>> os.kill(infos[0].pid, 15) >>> manager.get_all() [] …and that the underlying file is gone: $ ls /tmp/.tensorboard-info/ | wc -l 0 wchargin-branch: write-tensorboardinfo
manivaradarajan
approved these changes
Feb 7, 2019
wchargin-branch: tensorboardinfo-io
wchargin
added a commit
that referenced
this pull request
Feb 7, 2019
Summary: This commit wires up `TensorBoard.main` to the `TensorboardInfo` I/O introduced in #1806. Test Plan: Run `bazel run //tensorboard -- --logdir ./whatever/`, then verify that an info file has been created… $ ls /tmp/.tensorboard-info/ pid-85532.info …and that the file is visible to the Python APIs: $ python >>> from tensorboard import manager >>> infos = manager.get_all() >>> len(infos) 1 >>> infos[0].pid 85532 >>> infos[0].port 6006 Then, SIGTERM the server and verify that this is reflected from Python… >>> import os >>> os.kill(infos[0].pid, 15) >>> manager.get_all() [] …and that the underlying file is gone: $ ls /tmp/.tensorboard-info/ | wc -l 0 wchargin-branch: write-tensorboardinfo
wchargin
added a commit
that referenced
this pull request
Feb 7, 2019
Summary: This commit wires up `TensorBoard.main` to the `TensorboardInfo` I/O introduced in #1806. Test Plan: Run `bazel run //tensorboard -- --logdir ./whatever/`, then verify that an info file has been created… $ ls /tmp/.tensorboard-info/ pid-85532.info …and that the file is visible to the Python APIs: $ python >>> from tensorboard import manager >>> infos = manager.get_all() >>> len(infos) 1 >>> infos[0].pid 85532 >>> infos[0].port 6006 Then, SIGTERM the server and verify that this is reflected from Python… >>> import os >>> os.kill(infos[0].pid, 15) >>> manager.get_all() [] …and that the underlying file is gone: $ ls /tmp/.tensorboard-info/ | wc -l 0 wchargin-branch: write-tensorboardinfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This commit implements functions
write_info_file,remove_info_file,and
get_allon thetensorboard.managermodule. See docs for details.Supersedes part of #1795.
Test Plan:
Integration tests included; run
bazel test //tensorboard:manager_test.wchargin-branch: tensorboardinfo-io