program: write TensorboardInfo on server startup #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wchargin
force-pushed
the
wchargin-tensorboardinfo-io
branch
from
3f594d6
to
f0884e6
Compare
wchargin
force-pushed
the
wchargin-write-tensorboardinfo
branch
from
1fd9e27
to
7f4afc4
Compare
nfelt
approved these changes
Feb 5, 2019
wchargin
force-pushed
the
wchargin-write-tensorboardinfo
branch
from
7f4afc4
to
b22bca7
Compare
wchargin
force-pushed
the
wchargin-tensorboardinfo-io
branch
from
311af09
to
5216432
Compare
wchargin
force-pushed
the
wchargin-write-tensorboardinfo
branch
from
b22bca7
to
3bb60aa
Compare
stephanwlee
approved these changes
Feb 6, 2019
wchargin
force-pushed
the
wchargin-write-tensorboardinfo
branch
from
3bb60aa
to
e9d9d75
Compare
wchargin
force-pushed
the
wchargin-tensorboardinfo-io
branch
2 times, most recently
from
c62bcaa
to
41b4625
Compare
wchargin
force-pushed
the
wchargin-write-tensorboardinfo
branch
from
e9d9d75
to
bb0f6c0
Compare
Summary: This commit wires up `TensorBoard.main` to the `TensorboardInfo` I/O introduced in #1806. Test Plan: Run `bazel run //tensorboard -- --logdir ./whatever/`, then verify that an info file has been created… $ ls /tmp/.tensorboard-info/ pid-85532.info …and that the file is visible to the Python APIs: $ python >>> from tensorboard import manager >>> infos = manager.get_all() >>> len(infos) 1 >>> infos[0].pid 85532 >>> infos[0].port 6006 Then, SIGTERM the server and verify that this is reflected from Python… >>> import os >>> os.kill(infos[0].pid, 15) >>> manager.get_all() [] …and that the underlying file is gone: $ ls /tmp/.tensorboard-info/ | wc -l 0 wchargin-branch: write-tensorboardinfo
wchargin
force-pushed
the
wchargin-write-tensorboardinfo
branch
from
bb0f6c0
to
9b17fd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This commit wires up
TensorBoard.mainto theTensorboardInfoI/Ointroduced in #1806.
Test Plan:
Run
bazel run //tensorboard -- --logdir ./whatever/, then verify thatan info file has been created…
…and that the file is visible to the Python APIs:
Then, SIGTERM the server and verify that this is reflected from Python…
…and that the underlying file is gone:
wchargin-branch: write-tensorboardinfo