notebook: relocate to %load_ext tensorboard
#2119
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
“Drop the
.notebook
. It’s cleaner.” (Fixes #1857.)Using
%load_ext tensorboard.notebook
now gives users a helpful error.This is a breaking change, which we think is okay because (a) notebook
support was always explicitly marked as “alpha” in release notes and
“experimental” in the code, and (b) notebooks are meant to be run
interactively, so the fix will be easy and immediate.
Test Plan:
Built the Pip package and installed it into a new virtualenv, then
verified that
%load_ext tensorboard.notebook
properly emits an errormessage, which directs users to the working
%load_ext tensorboard
:Tested the above with
tf-nightly
andtf-nightly-2.0-preview
. Alsoverified that the
getting_started.ipynb
notebook still works, fromstart to finish, within the new virtualenv.
Verified that there are no lingering references to the old endpoint:
wchargin-branch: notebook-extension-at-root