manager: make TensorBoardInfo directory universally accessible and useful #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fixes #2010. This patch is primarily directed at Unices. On Windows, the underlying problem should not be an issue, because the default temporary directory seems to be user-scoped (e.g., `C:\Users\wchargin\AppData\Local\Temp`). Test Plan: Unit tests added. Before this change, the first test has an assertion error (`'0o755' != '0o777'`) and the second test has an I/O error trying to write to a non-writable directory. After this change, all tests pass. Tested only on Linux. wchargin-branch: info-dir-mode
|
Rats. Missed opportunity to title the commit, “Make |
nfelt
changed the title
|
I should note that I did test that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #2010.
This patch is primarily directed at Unices. On Windows, the underlying
problem should not be an issue, because the default temporary directory
seems to be user-scoped (e.g.,
C:\Users\wchargin\AppData\Local\Temp).Test Plan:
Unit tests added. Before this change, the first test has an assertion
error (
'0o755' != '0o777') and the second test has an I/O error tryingto write to a non-writable directory. After this change, all tests pass.
Tested only on Linux.
wchargin-branch: info-dir-mode