workspace: upgrade to Bazel 3.0.0, rules_rust latest #4296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Bazel rule repositories (Go, Rust, protobuf, …) are migrating to a new linker API introduced as a breaking Bazel change: <bazelbuild/bazel#10860> This API requires Bazel 3.0.0, which is fine for us. Test Plan: Everything builds, all tests pass, and TensorBoard looks okay enough. wchargin-branch: bazel-3.0.0 wchargin-source: 5c02209b5c25cbeab580c28c549df53c6d501ae4
|
Sent upstream bazelbuild/rules_rust#484 for CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Bazel rule repositories (Go, Rust, protobuf, …) are migrating to a new
linker API introduced as a breaking Bazel change:
bazelbuild/bazel#10860
This API requires Bazel 3.0.0, which is fine for us.
Test Plan:
Everything builds, all tests pass, and TensorBoard looks okay enough,
including the dynamically loaded projector plugin.
wchargin-branch: bazel-3.0.0