workspace: upgrade to Bazel 3.5.0, rules_rust latest (1/n) #4301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Bazel rule repositories (Go, Rust, protobuf, …) are migrating to a new linker API introduced as a breaking Bazel change: <bazelbuild/bazel#10860> This API requires Bazel 3.0.0, which is fine for us. We also need to upgrade to 3.5.0 for incoming Node changes, so we do that now, too. Test Plan: Everything builds, all tests pass, and TensorBoard looks okay enough. wchargin-branch: bazel-3.5.0 wchargin-source: 8ace612
stephanwlee
approved these changes
Nov 9, 2020
wchargin-branch: bazel-3.5.0 wchargin-source: a206e8a18d1cca5eb1ffb2f10b85ba5a94e98103
wchargin-branch: bazel-3.5.0 wchargin-source: f3add0dff7a6e6193d400a393e1159a4c6d76351
wchargin-branch: bazel-3.5.0 wchargin-source: f3add0dff7a6e6193d400a393e1159a4c6d76351
wchargin
changed the title
|
Closing in favor of #4319. Thanks, @stephanwlee! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Bazel rule repositories (Go, Rust, protobuf, …) are migrating to a new
linker API introduced as a breaking Bazel change:
bazelbuild/bazel#10860
This API requires Bazel 3.0.0, which is fine for us. We also need to
upgrade to 3.5.0 for incoming Node changes, so we do that now, too.
Because we can’t manage to build our whole test suite at once on CI
resources, this patch also disables all the builds. We’ll re-enable them
incrementally. See #4092, et al. for prior art.
Test Plan:
Locally, everything builds, all tests pass, and TensorBoard looks okay
enough.
wchargin-branch: bazel-3.5.0