Hparams: Allow users to load more Hparams if they are not all included in default. #6780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmd3k
force-pushed
the
hparams-20240307-load-more-anyways-2
branch
from
26e5e85
to
170284d
Compare
bmd3k
force-pushed
the
hparams-20240307-load-more-anyways-2
branch
from
170284d
to
f968643
Compare
Instead of the way I was previously removing the flakiness.
rileyajones
approved these changes
Mar 11, 2024
| <button mat-stroked-button (click)="loadAllColumnsClicked()"> | ||
| Load all anyway | ||
| </button> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div #columnList class="column-list"> |
There was a problem hiding this comment.
We may want to wrap the list of columns in a virtual scroll viewbox prior to launching the data project
https://material.angular.io/cdk/scrolling/overview#cdk-virtual-scroll-overview
There was a problem hiding this comment.
Thanks, added that suggestion to our list of tasks. We should at least play with it.
bmd3k
added a commit
that referenced
this pull request
Mar 22, 2024
We limit the number of hparams retrieved and rendered in the Hparams plugin. Otherwise the plugin can become very slow and even crash. Unlike #6780, we do not provide an option for loading more in the Hparams plugin. We may provide this option later if there is demand. But generally we think 1000 should be enough, especially if the underlying hparams provider is sorting the results with "differs" fields first. 
AnuarTB
pushed a commit
to AnuarTB/tensorboard
that referenced
this pull request
May 3, 2024
…d in default. (tensorflow#6780) In tensorflow#6777 we limited the number of hparams we load by default. Now we add the option for the user to load all hparams in spite of the performance implications. OSS Light Mode:  OSS Dark Mode:  Internal Light Mode:  Internal Dark Mode: 
AnuarTB
pushed a commit
to AnuarTB/tensorboard
that referenced
this pull request
May 3, 2024
…low#6807) We limit the number of hparams retrieved and rendered in the Hparams plugin. Otherwise the plugin can become very slow and even crash. Unlike tensorflow#6780, we do not provide an option for loading more in the Hparams plugin. We may provide this option later if there is demand. But generally we think 1000 should be enough, especially if the underlying hparams provider is sorting the results with "differs" fields first. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6777 we limited the number of hparams we load by default.
Now we add the option for the user to load all hparams in spite of the performance implications.
OSS Light Mode:
OSS Dark Mode:
Internal Light Mode:
Internal Dark Mode:
