Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltips for columns with names that don't match display names. #6781

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

bmd3k
Copy link
Contributor

@bmd3k bmd3k commented Mar 8, 2024

Add tooltips for hparam column names when the name does not match the display name (using case-insentive comparison).

@bmd3k bmd3k requested a review from yatbear March 8, 2024 15:34
@bmd3k bmd3k force-pushed the hparams-20240308-name-tooltips branch from aee8636 to 0fa006f Compare March 8, 2024 15:35
@bmd3k
Copy link
Contributor Author

bmd3k commented Mar 8, 2024

Note that the CI failure is due to flaky tests and is being addressed as part of #6780.

Copy link
Member

@yatbear yatbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding "names that don't match display names", are these mainly from the hparams with long names parsed from an embedded dictionary?

@bmd3k
Copy link
Contributor Author

bmd3k commented Mar 11, 2024

Regarding "names that don't match display names", are these mainly from the hparams with long names parsed from an embedded dictionary?

Yes, in practice these are the long names for hparams.

@bmd3k bmd3k merged commit 571a6a6 into tensorflow:master Mar 11, 2024
13 checks passed
AnuarTB pushed a commit to AnuarTB/tensorboard that referenced this pull request May 3, 2024
…ensorflow#6781)

Add tooltips for hparam column names when the name does not match the
display name (using case-insentive comparison).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants