Skip to content

Commit

Permalink
[Triton][NFC] Clean-up duplicate bug reference
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 637922896
  • Loading branch information
Moerafaat authored and tensorflower-gardener committed May 28, 2024
1 parent efad0fe commit 092d33a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions third_party/xla/xla/service/gpu/gemm_fusion_autotuner_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ ENTRY e {
EXPECT_TRUE(RunAndCompare(kHloText, ErrorSpec{/*aabs=*/1e-3, /*arel=*/1e-3}));
}

// Modify block_k back to 16 once b/331362083 is fixed.
// Modify block_k back to 16 once b/337839570 is fixed.
TEST_F(GemmFusionAutotunerTest, DoNotRunAutotuningKernelSpillingRegisters) {
const std::string kHloText = R"(
HloModule m
Expand Down Expand Up @@ -468,7 +468,7 @@ ENTRY %e {
"Compilation result discarded due to register spilling")));
}

// Modify block_k back to 16 once b/331362083 is fixed.
// Modify block_k back to 16 once b/337839570 is fixed.
TEST_F(GemmFusionAutotunerTest,
DoNotFilterOutAutotuningKernelSpillingRegisters) {
const std::string kHloText = R"(
Expand Down Expand Up @@ -510,7 +510,7 @@ ENTRY %e {
EXPECT_NE(executable, nullptr);
}

// Modify block_k back to 16 once b/331362083 is fixed.
// Modify block_k back to 16 once b/337839570 is fixed.
TEST_F(GemmFusionAutotunerTest, RunAutotuningKernelNotSpillingRegisters) {
const std::string kHloText = R"(
HloModule m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ INSTANTIATE_TEST_SUITE_P(RewriteTestSuite, MixedTypeTest,
// TritonRewriteTest2Params{F32, BF16},
MixTypeParams{S8, BF16, 24, 40, 8},
// Modify the case below to use k = 32 instead of
// 16 once b/331362083 is fixed.
// 16 once b/337839570 is fixed.
MixTypeParams{S8, F16, 80, 32, 32, 1e-3, 1e-6},
MixTypeParams{F16, F32, 127, 3, 300, 1e-2, 1e-2},
MixTypeParams{F16, BF16, 544, 96, 16, 1e-3, 1e-3},
Expand Down

0 comments on commit 092d33a

Please sign in to comment.