Skip to content

Commit

Permalink
Fix for the broken --config=rocm build.
Browse files Browse the repository at this point in the history
Note: This ia a different PR from #28189 (same symptom, different cause and fix)

The `--config=rocm` build was broken by the following commit.

9b1b3df

The changes made by the above commit were missing a couple of changes for the ROCm platform, whias was leading to the build failure. Adding those changes to make the `--config=rocm` build working again.
  • Loading branch information
deven-amd committed Apr 29, 2019
1 parent c38b41d commit 7179147
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tensorflow/stream_executor/rocm/rocm_diagnostics.cc
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,9 @@ port::StatusOr<DriverVersion> Diagnostician::FindDsoVersion() {
}
string dso_version = dot + strlen(so_suffix);
// TODO(b/22689637): Eliminate the explicit namespace if possible.
string stripped_dso_version = absl::StripSuffix(dso_version, ".ld64");
auto stripped_dso_version = absl::StripSuffix(dso_version, ".ld64");
auto result = static_cast<port::StatusOr<DriverVersion>*>(data);
*result = rocm::StringToDriverVersion(stripped_dso_version);
*result = rocm::StringToDriverVersion(string(stripped_dso_version));
return 1;
}
return 0;
Expand Down Expand Up @@ -210,8 +210,8 @@ port::StatusOr<DriverVersion> Diagnostician::FindKernelModuleVersion(
size_t space_index = version_and_rest.find(" ");
auto kernel_version = version_and_rest.substr(0, space_index);
// TODO(b/22689637): Eliminate the explicit namespace if possible.
string stripped_kernel_version = absl::StripSuffix(kernel_version, ".ld64");
return rocm::StringToDriverVersion(stripped_kernel_version);
auto stripped_kernel_version = absl::StripSuffix(kernel_version, ".ld64");
return rocm::StringToDriverVersion(string(stripped_kernel_version));
}

void Diagnostician::WarnOnDsoKernelMismatch(
Expand Down

0 comments on commit 7179147

Please sign in to comment.