Skip to content

Commit

Permalink
Add security advisory for vuln #61 in 2022
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 449101581
  • Loading branch information
mihaimaruseac authored and tensorflower-gardener committed May 17, 2022
1 parent aa0b583 commit a3e14a0
Showing 1 changed file with 37 additions and 0 deletions.
37 changes: 37 additions & 0 deletions tensorflow/security/advisory/tfsa-2022-061.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
## TFSA-2022-061: Missing validation causes `TensorSummaryV2` to crash

### CVE Number
CVE-2022-29193

### Impact
The implementation of [`tf.raw_ops.TensorSummaryV2`](https://github.com/tensorflow/tensorflow/blob/f3b9bf4c3c0597563b289c0512e98d4ce81f886e/tensorflow/core/kernels/summary_tensor_op.cc#L33-L58) does not fully validate the input arguments. This results in a `CHECK`-failure which can be used to trigger a denial of service attack:

```python
import numpy as np
import tensorflow as tf

tf.raw_ops.TensorSummaryV2(
tag=np.array('test'),
tensor=np.array(3),
serialized_summary_metadata=tf.io.encode_base64(np.empty((0))))
```

The code assumes `axis` is a scalar but there is no validation for this.

```cc
const Tensor& serialized_summary_metadata_tensor = c->input(2);
// ...
ParseFromTString(serialized_summary_metadata_tensor.scalar<tstring>()(),
v->mutable_metadata());
```
### Patches
We have patched the issue in GitHub commit [290bb05c80c327ed74fae1d089f1001b1e2a4ef7](https://github.com/tensorflow/tensorflow/commit/290bb05c80c327ed74fae1d089f1001b1e2a4ef7).
The fix will be included in TensorFlow 2.9.0. We will also cherrypick this commit on TensorFlow 2.8.1, TensorFlow 2.7.2, and TensorFlow 2.6.4, as these are also affected and still in supported range.
### For more information
Please consult [our security guide](https://github.com/tensorflow/tensorflow/blob/master/SECURITY.md) for more information regarding the security model and how to contact us with issues and questions.
### Attribution
This vulnerability has been reported by Neophytos Christou from Secure Systems Lab at Brown University and Hong Jin from Singapore Management University.

0 comments on commit a3e14a0

Please sign in to comment.